Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to a package installable via pip #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edbordin
Copy link

@edbordin edbordin commented Oct 2, 2017

I just made this into a package that can be installed via pip. Thought it was a simple and useful enough change that you might be happy to merge it!

If you're worried about package maintenance, this is still useful even without submitting to pypi as you can make pip install directly from github.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot
Copy link

CLAs look good, thanks!

@edbordin edbordin force-pushed the master branch 4 times, most recently from 6c00116 to 3ab919b Compare October 2, 2017 23:09
@edbordin
Copy link
Author

edbordin commented Oct 2, 2017

Just noticed I hadn't set the package name correctly in setup.py, should be fixed now.

You may have gotten some spam from me fiddling with the git committer and author and having to force push to remove a few mistakes along the way...

@Wizardofoddz
Copy link

Interesting, worth a i.//0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants