Skip to content

Commit

Permalink
Ignore ECJ test in JDK 10 and 11 since ECJ doesn't work for us in tho…
Browse files Browse the repository at this point in the history
…se versions of the JDK.

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=223350143
  • Loading branch information
netdpb authored and ronshapiro committed Dec 3, 2018
1 parent e0b8c93 commit 2a5d885
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,14 @@
*/
@RunWith(Parameterized.class)
public class OverridesTest {
private static final ImmutableSet<String> TOO_NEW_FOR_ECJ = ImmutableSet.of("9", "10", "11");

@Parameterized.Parameters(name = "{0}")
public static List<Object[]> data() {
List<Object[]> compilerTypes = new ArrayList<Object[]>();
compilerTypes.add(new Object[] {CompilerType.JAVAC});
if (!"9".equals(JAVA_SPECIFICATION_VERSION.value())) {
// TODO(emcmanus): make this test pass with ECJ on Java 9.
if (!TOO_NEW_FOR_ECJ.contains(JAVA_SPECIFICATION_VERSION.value())) {
// TODO(emcmanus): make this test pass with ECJ on Java > 8.
// Currently it complains because it can't find java.lang.Object. Probably we need a newer
// version of ECJ.
compilerTypes.add(new Object[] {CompilerType.ECJ});
Expand Down

0 comments on commit 2a5d885

Please sign in to comment.