Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libFuzzer][chrome] Dont set an rss_limit_mb. #4135

Merged
merged 2 commits into from
Aug 1, 2024
Merged

[libFuzzer][chrome] Dont set an rss_limit_mb. #4135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7b68db
[libFuzzer][chrome] Dont set an rss_limit_mb.
jonathanmetzman Aug 1, 2024
ededc0e
fix
jonathanmetzman Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/clusterfuzz/_internal/bot/fuzzers/libFuzzer/fuzzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"""libFuzzer fuzzer."""
import psutil

from clusterfuzz._internal.base import utils
from clusterfuzz._internal.bot.fuzzers import builtin
from clusterfuzz._internal.bot.fuzzers import options
from clusterfuzz._internal.bot.fuzzers.libFuzzer import constants
Expand Down Expand Up @@ -44,7 +45,10 @@ def get_arguments(fuzzer_path) -> options.FuzzerArguments:
if timeout is None or timeout > constants.DEFAULT_TIMEOUT_LIMIT:
arguments[constants.TIMEOUT_FLAGNAME] = constants.DEFAULT_TIMEOUT_LIMIT

if not rss_limit_mb:
if not rss_limit_mb and utils.is_chromium():
# TODO(metzman/alhijazi): Monitor if we are crashing the bots.
arguments[constants.RSS_LIMIT_FLAGNAME] = 0
elif not rss_limit_mb:
arguments[constants.RSS_LIMIT_FLAGNAME] = constants.DEFAULT_RSS_LIMIT_MB
else:
# psutil gives the total amount of memory in bytes, but we're only dealing
Expand Down
Loading