Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/gcsblob: add support for forcing an authenticated client #3273

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Jul 19, 2023

Fixes #2965.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #3273 (c225a4c) into master (0e5728d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3273      +/-   ##
==========================================
+ Coverage   77.47%   77.59%   +0.11%     
==========================================
  Files         104      104              
  Lines       13710    13718       +8     
==========================================
+ Hits        10622    10644      +22     
+ Misses       2350     2339      -11     
+ Partials      738      735       -3     
Impacted Files Coverage Δ
blob/gcsblob/gcsblob.go 87.90% <100.00%> (+0.26%) ⬆️

... and 3 files with indirect coverage changes

@vangent vangent merged commit 8cab06e into google:master Jul 19, 2023
6 checks passed
@vangent vangent deleted the gcsunauth branch July 19, 2023 18:45
ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob/gcsblob: Support unauthenticated credentials for public buckets
1 participant