Debug Overlay #282
Open
Debug Overlay #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjiagoogle
requested review from
yasith,
Kimblebee and
temcguir
and removed request for
yasith
Jaehwa-Noh
reviewed
Nov 10, 2024
...ew/src/main/java/com/google/jetpackcamera/feature/preview/ui/debug/DebugOverlayComponents.kt
Outdated
Show resolved
Hide resolved
…k-camera-app into david/debugOverlay
Jaehwa-Noh
reviewed
Nov 14, 2024
| @@ -153,7 +153,7 @@ class CameraXCameraUseCaseTest { | |||
| Dispatchers.Default, | |||
| constraintsRepository | |||
| ).apply { | |||
| initialize(appSettings, CameraUseCase.UseCaseMode.STANDARD) | |||
| initialize(appSettings, CameraUseCase.UseCaseMode.STANDARD) {} | |||
There was a problem hiding this comment.
Is there any way to omit the empty bracket for the callback here and other places?
What about set null as default value?
| @@ -44,7 +44,8 @@ interface CameraUseCase { | |||
| suspend fun initialize( | |||
| cameraAppSettings: CameraAppSettings, | |||
| useCaseMode: UseCaseMode, | |||
| isDebugMode: Boolean = false | |||
| isDebugMode: Boolean = false, | |||
| cameraPropertiesJSONCallback: (result: String) -> Unit | |||
There was a problem hiding this comment.
Is there any way to omit the empty bracket for this callback?
https://github.com/google/jetpack-camera-app/pull/282/files#diff-ddcefa1c42c7568a303536cd50adbf7c72115bb8ba254759ae5fd88f251e8167R156
What about set null as default value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current has two options: set zoom ratio and show camera properties
Screen.Recording.2024-11-07.at.3.59.30.PM.mov