Improve jcc #10783
Merged
Improve jcc #10783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonathanmetzman
commented
Aug 2, 2023
•
jonathanmetzman
commented
- Put it in a better location on disk.
- Move it to its own directory.
- Add tests.
- Make jcc able to find missing headers.
oliverchang
reviewed
Aug 3, 2023
| return false, true | ||
| } | ||
| ReplaceMissingHeaderInFile(filename, missingHeader, newHeaderPath) | ||
| return false, true |
There was a problem hiding this comment.
should this be true, true?
it's also a bit confusing what these states are.
Is it possible to simplify this into a single bool value indicating whether or not we should keep trying to compile?
There was a problem hiding this comment.
The second value is whether there are more broken headers. I'll use named return values.
I'm not sure I can combine them though.
DonggeLiu
approved these changes
Aug 10, 2023
| retcode, out, err := compile("clang++", cmdline) | ||
| fmt.Println(retcode) | ||
| fmt.Println(out) | ||
| fmt.Println(err) |
There was a problem hiding this comment.
Would it be better to only print them if there is an error?
There was a problem hiding this comment.
Nope. The normal behavior of compilers is to print even when there's no error.
|
PTAL oliver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.