Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: fix unittest #12161

Closed
wants to merge 1 commit into from
Closed

infra: fix unittest #12161

wants to merge 1 commit into from

Conversation

DavidKorczynski
Copy link
Collaborator

@DavidKorczynski DavidKorczynski commented Jul 4, 2024 •
edited
Loading

This is holding back #12160 which is needed for fixing the base builder

@DavidKorczynski
infra: fix unittest
5427d84 
Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

Ref: #12153 (comment)

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun skip

maflcko
maflcko approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavidKorczynski
Copy link
Collaborator Author

DavidKorczynski commented Jul 4, 2024 •
edited
Loading

Tests (except the one that is being fixed) are failing because of #12160 -- this is good to go

@DavidKorczynski
Copy link
Collaborator Author

I've pushed the changes to #12160 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maflcko maflcko maflcko approved these changes

@AdamKorcz AdamKorcz AdamKorcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidKorczynski @maflcko @AdamKorcz