Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code complexity related to maps #2378

Open
1 of 3 tasks
pav-kv opened this issue Mar 1, 2021 · 2 comments
Open
1 of 3 tasks

Reduce code complexity related to maps #2378

pav-kv opened this issue Mar 1, 2021 · 2 comments
Labels

Comments

@pav-kv
Copy link
Contributor

pav-kv commented Mar 1, 2021

Some of the code is unnecessarily complex because previously it tried to accommodate both Log and Map trees. After maps removal [#2284] it makes sense to minimize this code, so that it's log-specific. If anything related to maps reappears in the repo, it still makes sense to keep the code decoupled to a greater degree than previously.

Examples:

  • storage/cache can be removed completely, or significantly simplified.
  • The NodeID&co types should be made log-specific. It likely needs to be replaced by a simple compact.NodeID, whereas for maps the NodeID2 type is more suitable.
  • The LogStorage/TreeStorage/MapStorage interfaces can be reduced.
@mhutchinson
Copy link
Contributor

@pavelkalinnikov is the checklist in the original comment still accurately tracking the remaining work on this?

@pav-kv
Copy link
Contributor Author

pav-kv commented Jun 10, 2022

Yes, it still looks relevant.

@pav-kv pav-kv removed their assignment Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants