Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeID: Remove unused BigInt format #2379

Merged
merged 2 commits into from
Mar 2, 2021
Merged

NodeID: Remove unused BigInt format #2379

merged 2 commits into from
Mar 2, 2021

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Mar 1, 2021

This format was only used by HStar2 which was recently removed.

#2378

@pav-kv pav-kv changed the title Remove unused stuff NodeID: Remove unused BigInt format Mar 2, 2021
@pav-kv pav-kv marked this pull request as ready for review March 2, 2021 10:39
@pav-kv pav-kv requested a review from a team as a code owner March 2, 2021 10:39
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2379 (4df6d3f) into master (3615e67) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2379      +/-   ##
==========================================
- Coverage   66.05%   65.84%   -0.21%     
==========================================
  Files         107      106       -1     
  Lines        7834     7745      -89     
==========================================
- Hits         5175     5100      -75     
+ Misses       2117     2109       -8     
+ Partials      542      536       -6     
Impacted Files Coverage Δ
merkle/smt/hstar3.go 90.90% <ø> (ø)
storage/tree/node.go 94.61% <ø> (+1.23%) ⬆️
log/operation_manager.go 87.30% <0.00%> (-1.06%) ⬇️
client/log_client.go 70.93% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc7219...4df6d3f. Read the comment docs.

@pav-kv pav-kv merged commit 6b396b7 into google:master Mar 2, 2021
@pav-kv pav-kv deleted the rm_stuff branch March 2, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants