Strip @NullMarked from GWT/J2CL artifact.
#1360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
We already strip `@Nullable` because of [a GWT bug with type-use annotations](gwtproject/gwt#10020) (recently fixed!). But because of our usages of `@NullMarked`, the `@Nullable` stripping makes all types non-null. To avoid that, we strip `@NullMarked`, too. RELNOTES=Changed our GWT/J2CL artifact to omit usages of `@NullMarked`. This was making all our types non-null in those environments, since we don't yet use `@Nullable` in the GWT/J2CL artifact. PiperOrigin-RevId: 696631127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip
@NullMarkedfrom GWT/J2CL artifact.We already strip
@Nullablebecause of a GWT bug with type-use annotations (recently fixed!). But because of our usages of@NullMarked, the@Nullablestripping makes all types non-null. To avoid that, we strip@NullMarked, too.RELNOTES=Changed our GWT/J2CL artifact to omit usages of
@NullMarked. This was making all our types non-null in those environments, since we don't yet use@Nullablein the GWT/J2CL artifact.