Refactor Terraform

[kamaljeeti]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:#2918

Closes #2918

Special notes for your reviewer:

[agones-bot]

Build Succeeded 🥳

Build Id: 98c8940c-a528-4097-9066-7a1cbff0c275

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-607b347
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-607b347
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-607b347-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-607b347
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-607b347
• Linux C++ SDK (build): agonessdk-1.43.0-dev-607b347-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.43.0-dev-607b347.zip

A preview of the website (the last 30 builds are retained):

• https://607b347-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3958/head:pr_3958 && git checkout pr_3958
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-607b347

[gongmax]

Did you run the make command to ensure all the commands you touched still work?

[kamaljeeti]

yes, it's working fine.

[agones-bot]

Build Succeeded 🥳

Build Id: 647bb194-de11-4df1-a247-c75d143bdc2e

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.44.0-dev-8c4b544
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.44.0-dev-8c4b544
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.44.0-dev-8c4b544-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.44.0-dev-8c4b544
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.44.0-dev-8c4b544
• Linux C++ SDK (build): agonessdk-1.44.0-dev-8c4b544-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.44.0-dev-8c4b544.zip

A preview of the website (the last 30 builds are retained):

• https://8c4b544-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3958/head:pr_3958 && git checkout pr_3958
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-8c4b544

[agones-bot]

Build Succeeded 🥳

Build Id: ea56a679-8f39-4006-8a77-b94a42394606

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.44.0-dev-be16362
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.44.0-dev-be16362
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.44.0-dev-be16362-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.44.0-dev-be16362
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.44.0-dev-be16362
• Linux C++ SDK (build): agonessdk-1.44.0-dev-be16362-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.44.0-dev-be16362.zip

A preview of the website (the last 30 builds are retained):

• https://be16362-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3958/head:pr_3958 && git checkout pr_3958
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-be16362