fleet: Allow increasing the fleet replicas during a rolling update #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Build Failed 😭 Build Id: 5b824c81-d928-421c-a81a-0d1977863049 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 64243212-5c9f-4cdf-bc35-27cd5a566d28 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Do you think #3762 fixes your use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Addresses #3970 by adding an extra boolean option to the fleet strategy that allows scaling up the replica count based on the
RollingUpdatesettings when patching the fleet config. This allows fleets to behave a bit more like aDeploymentwhen there is a redeployment. The new feature unblocks fleets that have all their replicas inAllocatedstate at the same time that a fleet update is requested. Previously, the newGameServerSetwould get stuck until one of the fleet'sGameServerwas deleted/brought back toReadystate.Which issue(s) this PR fixes:
Closes #3970
Special notes for your reviewer:
I'm not sure if this is a feature that the Agones maintainer want to support moving forward. This feature is useful for some of my use cases and it'd be difficult for me to maintain it ouside this repo. Happy to hear the opinions of others regarding this new functionality.