Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bad character from metrics markdown #3981

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

code-eg
Copy link
Contributor

@code-eg code-eg commented Sep 9, 2024

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

/kind bug

  1. What this PR does / Why we need it: The metrics markdown page is broken due to an extra character

Which issue(s) this PR fixes:

Closes #3976

Special notes for your reviewer:

Copy link

google-cla bot commented Sep 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added size/XS kind/bug These are bugs. labels Sep 9, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 30518b30-7379-439b-a31a-e47db1b3ee30

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3981/head:pr_3981 && git checkout pr_3981
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-1fdaa0e

Copy link
Collaborator

@peterzhongyi peterzhongyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But I'm not an approver so I'll also grab someone else.

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@igooch igooch enabled auto-merge (squash) September 9, 2024 20:16
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 54dc0837-7d7e-4d04-b106-ca94af6a7dfd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3981/head:pr_3981 && git checkout pr_3981
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-df5d362

@igooch igooch merged commit 871fe2f into googleforgames:main Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: "Available metrics" mark up was broken down
5 participants