Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golangci lint version upgrade v1.61.0 #3988

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

0xaravindh
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes: #3949

Closes #3949

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XL labels Sep 17, 2024
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 67ba3955-fb92-4676-bf05-3c83802b6a08

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: e12c0ed2-f2c2-41a3-a2e4-e6e60a3d4892

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@0xaravindh 0xaravindh marked this pull request as ready for review September 19, 2024 08:54
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 6c603335-9d25-4523-adc5-4c66220d84e7

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 0a32a258-5f3e-4fbc-bf0a-5ecdfb33f86e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

go.mod Outdated
@@ -1,6 +1,8 @@
module agones.dev/agones

go 1.21
go 1.22.0
Copy link
Collaborator

@peterzhongyi peterzhongyi Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be 1.22 instead of 1.22.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated @peterzhongyi

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: a4e0f5f7-7017-4c28-b622-f0113bee8eb8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 463fe28f-a445-45ff-a6bc-d9749e245a60

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: f13958d5-bab5-451f-9e15-781285f3fab0

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 51bc6965-3c3d-4b41-a2d0-52cce6e257f3

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

github-actions bot commented Oct 1, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 7de13ef0-54d5-4538-b972-af6ab21a2b93

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

github-actions bot commented Oct 1, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 6956a2d6-510d-43da-a3c4-1086cf05f866

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

github-actions bot commented Oct 1, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 8da229b7-744f-443f-a8fa-51e22435926c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

github-actions bot commented Oct 2, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 290c6dd1-aafe-4bd5-b133-f13d742d236a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

github-actions bot commented Oct 2, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: b1a6b6d2-a65c-440b-b8e8-a52ac5d415b6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Golang 1.22.6
5 participants