Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Trace' to LogLevel in GameServer.Spec.SdkServer #3995

Merged
merged 13 commits into from
Oct 1, 2024

Conversation

0xaravindh
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes: #3969

Closes #3969

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Sep 24, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 4d2e7967-5a5a-471e-9025-9c1e5b8ab506

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 8c7eee32-1727-41de-be5f-b367ae1bf941

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3995/head:pr_3995 && git checkout pr_3995
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-a96ad67

@gongmax
Copy link
Collaborator

gongmax commented Sep 27, 2024

Did you perform any manual test as describe here

@0xaravindh
Copy link
Contributor Author

Did you perform any manual test as describe here

Yes @gongmax , I did the manual test with Trace debugging and checked the logs in the GameServer. Everything is working as expected.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 74e75b87-1db5-4a85-bad6-d86c8eb1b41a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3995/head:pr_3995 && git checkout pr_3995
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-400594e

@gongmax gongmax enabled auto-merge (squash) September 30, 2024 23:32
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 4b7c2b3d-6e87-4313-a6c7-300291d21b85

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3995/head:pr_3995 && git checkout pr_3995
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-264e19a

@gongmax gongmax merged commit fc60900 into googleforgames:main Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GameServer.Spec.SdkServer.LogLevel "Trace"
3 participants