Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build-e2e error #4009

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix the build-e2e error #4009

merged 1 commit into from
Oct 2, 2024

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Oct 2, 2024

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Currently all the ci failed at step build e2e with error Package 'python' has no installation candidate. Eg: https://pantheon.corp.google.com/cloud-build/builds/b0183fd6-46bf-43a5-8191-3ee9bb2593c4?project=agones-images&e=13803378&mods=build_data. Not sure why this started happening from yesterday, but looks like we don't need to install python in this step, so remove it to fix the issue.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 71121324-fc16-45dd-83bb-fb1296c7da06

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4009/head:pr_4009 && git checkout pr_4009
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-dd2273f

@gongmax gongmax changed the title Attempt fix Fix the build-e2e error Oct 2, 2024
Copy link
Collaborator

@peterzhongyi peterzhongyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongmax gongmax merged commit 9e840c8 into googleforgames:main Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants