Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Terraform scripts and docs to show how to create OKE cluster and install Agones #4023

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

ouxingning
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Besides AWS, GCP and Azure, OCI (Oracle Cloud Infrastructure) is another public cloud, OCI Kubernetes Engine (OKE) is one of its providing service, so I wrote Terraform scripts and documents to demonstrate how to create OKE cluster and install Angones, I hope contributing these Terraform scripts and documents, so I created this pull request.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:
My friend, thank you so much for your review.

@github-actions github-actions bot added kind/documentation Documentation for Agones size/L labels Oct 25, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 86bc9598-9e5a-48b0-8fa1-ff621623c490

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4023/head:pr_4023 && git checkout pr_4023
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-2a900c3

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a few tweaks!

examples/terraform-submodules/oke/module.tf Outdated Show resolved Hide resolved
examples/terraform-submodules/oke/module.tf Outdated Show resolved Hide resolved
examples/terraform-submodules/oke/terraform.auto.tfvars Outdated Show resolved Hide resolved
site/content/en/docs/Installation/Creating Cluster/oke.md Outdated Show resolved Hide resolved
site/content/en/docs/Installation/Terraform/oke.md Outdated Show resolved Hide resolved
site/content/en/docs/Installation/Terraform/oke.md Outdated Show resolved Hide resolved
@ouxingning
Copy link
Contributor Author

@markmandel Hi Mark, thanks for your review, I have fixed the above issues.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: ad62dc15-36c2-497d-9c3e-47f4dc2c0130

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4023/head:pr_4023 && git checkout pr_4023
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-79cfec3

@markmandel
Copy link
Member

Thanks for the ping - updating and taking another look.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 9208a1f6-b842-42d9-ab23-3628c6a76545

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4023/head:pr_4023 && git checkout pr_4023
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-ed0a946

@markmandel markmandel merged commit e8f7ccd into googleforgames:main Nov 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation for Agones size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants