POC: Cost Attribution Proposal 1.2 #9733
Conversation
ying-jeanne
force-pushed
the
poc-cost-attribution-2
branch
from
1d711e5
to
e7bf88c
Compare
pkg/costattribution/tracker.go
Outdated
|
|
||
| // we need the time stamp, since active series could have entered active stripe long time ago, and already evicted | ||
| // from the observed map but still in the active Stripe | ||
| func (t *Tracker) DecrementActiveSeries(lbs labels.Labels, value int64, ts time.Time) { |
There was a problem hiding this comment.
I think here we might still want ts, when we decrement a active series counter that are "active" we may want to keep the timestamp updated.
There was a problem hiding this comment.
Why would we want to update the timestamp of something that didn't have activity?
ying-jeanne
force-pushed
the
poc-cost-attribution-2
branch
from
fa91187
to
00d8c00
Compare
ying-jeanne
force-pushed
the
poc-cost-attribution-2
branch
from
00d8c00
to
4e75934
Compare
ying-jeanne
force-pushed
the
poc-cost-attribution-2
branch
from
5b093ab
to
0456d94
Compare
|
I reviewed mostly the existing code changes, skipping the costattribution package implementation for now. Please ping me back when this is addressed. Meanwhile, while I didn't look into |
Signed-off-by: Ying WANG <[email protected]>
Signed-off-by: Ying WANG <[email protected]>
Signed-off-by: Ying WANG <[email protected]>
pkg/costattribution/tracker.go
Outdated
| "go.uber.org/atomic" | ||
| ) | ||
|
|
||
| type Tracker interface { |
There was a problem hiding this comment.
I think we don't need an interface here, it just makes things more complex and slow. Now we can't compare two trackers by just comparing the pointers, and we expose too many internal details on exported method just to make that comparison.
There are only two implementations of Tracker: the one that does things and the one that is disabled, we can make the disabled one be the nil pointer of TrackerImpl (please rename that back to Tracker).
There was a problem hiding this comment.
removed the interface, and it checks for nil pointer in the receiver instead. commit 7f0b372
| func (c *ActiveSeries) ConfigDiffers(ctCfg asmodel.CustomTrackersConfig, caCfg costattribution.Tracker) bool { | ||
| if ctCfg.String() != c.CurrentConfig().String() { | ||
| return true | ||
| } | ||
| return !areTrackersEqual(caCfg, c.CurrentCostAttributionTracker()) | ||
| } |
There was a problem hiding this comment.
Since we have ConfigDiffers now, we don't need CurrentConfig or CurrentCostAttributionTracker methods, and we don't need to take mutex twice for them.
There was a problem hiding this comment.
addressed in this commit 698a5c6#diff-74600e3203a9faaa94f7231d161362da3e3223aa024eb324b903e5fc27bb9f3dR116
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.