Use URL-safe Base64 encoding for the topic name #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akhmetov
force-pushed
the
alexander-akhmetov/encode-topic-name
branch
3 times, most recently
from
eb56fae
to
4ef2524
Compare
There are some restrictions to what characters are allowed to use in a Grafana Live channel: https://github.com/grafana/grafana-plugin-sdk-go/blob/7470982de35f3b0bb5d17631b4163463153cc204/live/channel.go#L33 To comply with these restrictions, the topic is encoded using URL-safe base64 encoding. (RFC 4648; 5. Base 64 Encoding with URL and Filename Safe Alphabet)
alexander-akhmetov
force-pushed
the
alexander-akhmetov/encode-topic-name
branch
from
4ef2524
to
4c52831
Compare
|
Would love to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use url-safe base64 encoding to encode the topic name. It allows subscribing to topics with special characters in the name, for example
$SYS/+, etc.Fixes #111, #105, #90
How to test
Create a new MQTT data source:
tcp://host.docker.internal:1883Subscribe to
$SYS/my:topic/second/1in Explore