Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added github actions periodic build #2406

Merged
merged 31 commits into from
Nov 15, 2024
Merged

Added github actions periodic build #2406

merged 31 commits into from
Nov 15, 2024

Conversation

Renzovh
Copy link
Contributor

@Renzovh Renzovh commented Nov 7, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a3818d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graphcommerce ✅ Ready (Inspect) Visit Preview Nov 8, 2024 11:11am
graphcommerce-adobe-commerce ❌ Failed (Inspect) Nov 8, 2024 11:11am
graphcommerce-hygraph-dynamic-rows-ui ✅ Ready (Inspect) Visit Preview Nov 8, 2024 11:11am
magento-2.4.7 ✅ Ready (Inspect) Visit Preview Nov 8, 2024 11:11am

paales
paales requested changes Nov 8, 2024
View reviewed changes
.github/workflows/periodic-build.yml Show resolved Hide resolved
.github/workflows/periodic-build.yml Outdated
Comment on lines 41 to 43
- name: Install dependencies
run: yarn install && yarn postinstall

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install dependencies
run: yarn install && yarn postinstall

.github/workflows/periodic-build.yml Outdated

- name: Prepare and build graphcommerce
run: |
git clone -b main --depth 1 https://github.com/graphcommerce-org/graphcommerce.git && mkdir -p /tmp/graphcommerce-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary when checking out in graphcommerce (see above)

.github/workflows/periodic-build.yml Outdated
Comment on lines 47 to 48
cp -R graphcommerce/examples/magento-graphcms/. /tmp/graphcommerce-build && rm -rf graphcommerce
cd /tmp/graphcommerce-build && yarn && yarn codegen && yarn build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cp -R graphcommerce/examples/magento-graphcms/. /tmp/graphcommerce-build && rm -rf graphcommerce
cd /tmp/graphcommerce-build && yarn && yarn codegen && yarn build
cp -R graphcommerce/examples/magento-graphcms/. my-project && cd my-project
yarn
yarn codegen
yarn build

.github/workflows/periodic-build.yml Outdated
Comment on lines 55 to 67
- name: Upload success artifact
if: success()
uses: actions/upload-artifact@v3
with:
name: success-${{ matrix.version }}
path: /tmp/graphcommerce-build

- name: Upload failure artifact
if: failure()
uses: actions/upload-artifact@v3
with:
name: failure-${{ matrix.version }}
path: /tmp/graphcommerce-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine when one fails, everything fails

paales
paales reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@paales paales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After we've made this workflow for the main branch and everything works as expected. We create a new PR that targets the canary branch which has the modifications that are specific to that version, specifically node 22.

.github/workflows/periodic-build.yml Outdated
publish:
strategy:
matrix:
version: [18, 20, 22]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the main branch, it should be [18, 20]

.github/workflows/periodic-build.yml Outdated
- cron: 0 0 * * *
push:
branches:
- 'feature/periodic-release'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'feature/periodic-release'
- 'canary'

@paales paales merged commit 6dd5069 into main Nov 15, 2024
4 of 6 checks passed
@paales paales deleted the feature/periodic-release branch November 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paales paales paales requested changes

Assignees

@paales paales

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Renzovh @paales