Migrate from ethabi to alloy
#5692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isum
force-pushed
the
ion/migrate-to-alloy-rs
branch
from
a237082
to
9e19b0d
Compare
isum
force-pushed
the
ion/migrate-to-alloy-rs
branch
from
9e19b0d
to
a6a1cbf
Compare
mangas
reviewed
Nov 6, 2024
mangas
reviewed
Nov 6, 2024
mangas
approved these changes
Nov 6, 2024
|
We absolutely need to test this on the integration cluster before merging though |
mangas
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
ethabidependency and migrates the codebase toalloy.Closes #5669
The
ethabi::Tokenenum has fewer variants thanalloy_dyn_abi::DynSolValue, so the EthereumValueKind enum was extended to support function pointer kind.Todos