Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] fix placeholder ⌘ K in doc explorer search input for non mac devices, replace by Ctrl K #3751

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

dimaMachina
Copy link
Collaborator

fixes #3436

Screen.Recording.2024-08-24.at.15.56.21.mov
Screen.Recording.2024-08-24.at.15.55.38.mov

Copy link

changeset-bot bot commented Aug 24, 2024

🦋 Changeset detected

Latest commit: 459dd47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
codemirror-graphql Patch
@graphiql/react Patch
cm6-graphql Patch
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.32%. Comparing base (1a561b3) to head (459dd47).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3751      +/-   ##
==========================================
- Coverage   65.33%   65.32%   -0.01%     
==========================================
  Files         121      122       +1     
  Lines        7007     7003       -4     
  Branches     2262     2260       -2     
==========================================
- Hits         4578     4575       -3     
+ Misses       2412     2411       -1     
  Partials       17       17              
Files Coverage Δ
...ackages/codemirror-graphql/src/utils/jump-addon.ts 2.59% <100.00%> (ø)
packages/graphiql-react/src/editor/common.ts 100.00% <ø> (ø)
.../graphiql-react/src/explorer/components/search.tsx 61.11% <100.00%> (+0.36%) ⬆️
packages/graphiql-react/src/utility/is-macos.ts 100.00% <100.00%> (ø)
packages/graphiql/src/components/GraphiQL.tsx 78.57% <100.00%> (+0.15%) ⬆️

Copy link
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@dimaMachina dimaMachina merged commit b8538d8 into main Aug 24, 2024
14 checks passed
@dimaMachina dimaMachina deleted the cmd-k branch August 24, 2024 14:09
@acao acao mentioned this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[graphiql] Wrong Linux keyboard shortcut showing Mac cmd icon
1 participant