Change: Insert CVEs products from CPE matches table #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
This comment was marked as spam.
This comment was marked as spam.
jhelmold
approved these changes
Nov 11, 2024
mattmundell
reviewed
Nov 15, 2024
| quoted_software, cve_db_id); | ||
| g_free (quoted_software); | ||
| } | ||
| g_string_free (software, TRUE); |
There was a problem hiding this comment.
This is indented 2 to far (compare with the return below). Made me think that the free was happening inside the iteration above.
I find this cJSON_ArrayForEach style awkward, especially when the body is so large. I think this style makes it tricky for the auto indentation in editors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Insert CVEs products from CPE matches table when updating the SCAP from JSON files.
Why
Products column was not populated during CVE update from JSON
References
GEA-625