cache_page(per-page-cache) is not working correctly. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmuellegger
force-pushed
the
master
branch
2 times, most recently
from
e7c2eef
to
1edf2f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've integrated django-mobile into my website along with Django Cache enabled but I noticed that the per-page-cache were not read and the framework sends database queries even though the pages exist in cache.
After some investigation, I found out that the issue was caused by cache_page and CacheFlavourMiddleware not taking into account the sequence of the cache process.
Expected Sequence:
Set "HTTP_X_FLAVOUR" header -> FetchFromCacheMiddleware -> Set "Vary: X-Flavour" header -> UpdateCacheMiddleware
Current Sequence:
FetchFromCacheMiddleware -> Set "HTTP_X_FLAVOUR" header -> Set "Vary: X-Flavour" header -> UpdateCacheMiddleware
So FetchFromCacheMiddleware always looks for invalid cache.