-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let AndroidComponentAddress specify a target UserHandle #11670
Merged
Merged
+181
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is draft, but a few drive-by comments. Looks fair.
binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java
Outdated
Show resolved
Hide resolved
jdcormie
added
the
kokoro:force-run
Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary
label
Nov 11, 2024
grpc-kokoro
removed
the
kokoro:force-run
Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary
label
Nov 11, 2024
ejona86
reviewed
Nov 14, 2024
binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Nov 18, 2024
binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java
Outdated
Show resolved
Hide resolved
@ejona86 This change LGTM. Discussed with John offline for this change. Making the target UserHandle as part of the AndroidComponentAddress makes sense for two reasons:
|
Thanks Wentao! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target UserHandle is best modeled as part of the SocketAddress since it's part of the server's location.
This change allows a NameResolver to select different target users over time within a single Channel.