-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc,google-protobuf: migrate to homebrew-core #111
Conversation
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide more context?
It seems that since the formulas in this repo haven't been updated for the past 5years or so, the grpc/homebrew-grpc repository should basically be considered deprecated.
Perhaps we should delete the formulas from this repository and have the README.md basically say "don't use this, use the community-maintained homebrew formulas (that seems to be significantly more up-to-date)".
Is that aligned with that this PR is trying to do?
@@ -0,0 +1,4 @@ | |||
{ | |||
"grpc": "homebrew/core", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the same formula as https://formulae.brew.sh/formula/grpc
@@ -0,0 +1,4 @@ | |||
{ | |||
"grpc": "homebrew/core", | |||
"google-protobuf": "homebrew/core/protobuf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the same formula as https://formulae.brew.sh/formula/protobuf#default?
I created #112 to update the readme. |
@jtattermusch yeah, the context is basically to help migrate the formulae users to use the well maintained ones in homebrew-core, which leverages something called In other words, if the users installed the formulae using the taps, when they do Let me know if it makes better sense now. |
LGTM since this migrates the users of the very old and deprecated formulas to the community-provided ones (which are part of homebrew-core): |
relates to: