Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc,google-protobuf: migrate to homebrew-core #111

Merged
merged 2 commits into from
Jan 2, 2023
Merged

grpc,google-protobuf: migrate to homebrew-core #111

merged 2 commits into from
Jan 2, 2023

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 changed the title migrate grpc formula to homebrew-core grpc,google-protobuf: migrate to homebrew-core Apr 2, 2022
@chenrui333
Copy link
Contributor Author

Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide more context?

It seems that since the formulas in this repo haven't been updated for the past 5years or so, the grpc/homebrew-grpc repository should basically be considered deprecated.

Perhaps we should delete the formulas from this repository and have the README.md basically say "don't use this, use the community-maintained homebrew formulas (that seems to be significantly more up-to-date)".
Is that aligned with that this PR is trying to do?

@@ -0,0 +1,4 @@
{
"grpc": "homebrew/core",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the same formula as https://formulae.brew.sh/formula/grpc

@@ -0,0 +1,4 @@
{
"grpc": "homebrew/core",
"google-protobuf": "homebrew/core/protobuf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtattermusch
Copy link
Contributor

I created #112 to update the readme.

@chenrui333
Copy link
Contributor Author

@jtattermusch yeah, the context is basically to help migrate the formulae users to use the well maintained ones in homebrew-core, which leverages something called tap_migrations.json.

In other words, if the users installed the formulae using the taps, when they do brew upgrade xxx, they will automatically get redirected to use the formulae in homebrew-core.

Let me know if it makes better sense now.

@jtattermusch
Copy link
Contributor

LGTM since this migrates the users of the very old and deprecated formulas to the community-provided ones (which are part of homebrew-core):
https://formulae.brew.sh/formula/grpc
https://formulae.brew.sh/formula/protobuf

@jtattermusch jtattermusch merged commit 7cb5199 into grpc:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants