Skip to content

Commit

Permalink
Add isort to workflow (#8)
Browse files Browse the repository at this point in the history
* Add isort to workflow

* Fail on error

* Fix issue found by isort

* Fix typo in isort

* Fix isort
  • Loading branch information
XuanWang-Amos authored Nov 17, 2023
1 parent 0a9735b commit e084ff0
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/psm-interop.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,12 @@ jobs:
with:
options: "--check --config black.toml"
version: "23.3.0"

isort-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: isort/isort-action@v1
with:
configuration: "--diff --check-only --dont-follow-links --settings-path=black.toml"
isort-version: "5.9.2"
4 changes: 1 addition & 3 deletions framework/rpc/grpc_testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,14 @@
https://github.com/grpc/grpc/blob/master/src/proto/grpc/testing/test.proto
"""
import logging
import sys
from typing import Iterable, Optional, Tuple

import grpc
from grpc_health.v1 import health_pb2
from grpc_health.v1 import health_pb2_grpc

import framework.rpc
import sys

print(f">>>>path: {sys.path}")
from protos import empty_pb2
from protos import messages_pb2
from protos import test_pb2_grpc
Expand Down

0 comments on commit e084ff0

Please sign in to comment.