Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fallback] Set xDS configuration from the client #116

Merged
merged 5 commits into from
Aug 8, 2024
Merged

[fallback] Set xDS configuration from the client #116

merged 5 commits into from
Aug 8, 2024

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Aug 5, 2024 •
edited
Loading

Instead of hardcoding resource values in the control plane implementation, have test runner set the resources for each test case.

@eugeneo eugeneo changed the title Configure xDS resources on the client [fallback] Set xDS configuration from the client Aug 7, 2024
@eugeneo eugeneo marked this pull request as ready for review August 7, 2024 19:56
@eugeneo eugeneo requested a review from a team as a code owner August 7, 2024 19:56
@easwars easwars assigned eugeneo and unassigned easwars Aug 7, 2024
eugeneo
eugeneo commented Aug 8, 2024
View reviewed changes
Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reviews. I addressed the comments.

docker/go-control-plane/fallback-control-plane.go Outdated Show resolved Hide resolved
docker/go-control-plane/fallback-control-plane.go Show resolved Hide resolved
protos/grpc/testing/xdsconfig/xdsconfig.proto Outdated Show resolved Hide resolved
easwars
easwars approved these changes Aug 8, 2024
View reviewed changes
Copy link

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Go changes.

docker/go-control-plane/README.md Outdated Show resolved Hide resolved
XuanWang-Amos
XuanWang-Amos approved these changes Aug 8, 2024
View reviewed changes
framework/helpers/docker.py Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
eugeneo
eugeneo commented Aug 8, 2024
View reviewed changes
Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. I implemented the suggestions.

framework/helpers/docker.py Show resolved Hide resolved
tests/fallback_test.py Outdated Show resolved Hide resolved
@XuanWang-Amos XuanWang-Amos merged commit 8edbdb7 into grpc:main Aug 8, 2024
7 checks passed
@eugeneo eugeneo deleted the next-version branch August 8, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easwars easwars easwars approved these changes

@XuanWang-Amos XuanWang-Amos XuanWang-Amos approved these changes

Assignees

@eugeneo eugeneo

@XuanWang-Amos XuanWang-Amos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugeneo @easwars @XuanWang-Amos