Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Exclude remove_neg_test from Dualstack test suite" #138

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

XuanWang-Amos
Copy link
Collaborator

Reverts #133

We removed test_remove_neg from tests because we're seeing an issue where healthy endpoints were not present in EDS response, looks like the issue was fixed somehow, this case passed in the following manual runs:

I guess it's time for us to add back this test.

@XuanWang-Amos XuanWang-Amos merged commit a6a999e into main Oct 23, 2024
6 checks passed
@XuanWang-Amos XuanWang-Amos deleted the revert-133-aranjans-patch-1 branch October 23, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants