Make it possible to configure a metrics port in pods #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdfzcq
changed the title
paulosjca
requested changes
Mar 13, 2024
fdfzcq
force-pushed
the
add-support-for-metrics-port
branch
from
ad5a816
to
a209c7e
Compare
paulosjca
added
enhancement
paulosjca
approved these changes
Apr 3, 2024
podbuilder/podbuilder_test.go
Outdated
| Expect(getNames(runContainer.Ports)).NotTo(ContainElement("metrics")) | ||
| }) | ||
|
|
||
| It("does not expose the metrics port if not set", func() { |
There was a problem hiding this comment.
Should probably be "exposes the metrics port if set".
There was a problem hiding this comment.
oops sorry I missed this comment, thank you for fixing it! @paulosjca
paulosjca
pushed a commit
to paulosjca/test-infra
that referenced
this pull request
Apr 8, 2024
paulosjca
pushed a commit
to paulosjca/test-infra
that referenced
this pull request
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently includes changes from #390
We (Spotify) are currently using this framework to set up automated benchmarking for our internal gRPC. While we have metrics from the driver for performance comparison, we would like to scrape and see actual metrics from the client/server in many cases. This PR adds a configuration
metricsPortfor both client and server. A metrics port with configured port number is exposed in the pod if configured, otherwise no extra ports are exposed.