Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: (issue#48) Add option to install Python3 for projects using TF Lambda module #49

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

yiskaneto
Copy link

@yiskaneto yiskaneto commented Feb 9, 2024

Description

Fixes #48

  • Added the following 2 non-required inputs to install Python3 for projects that need to use the AWS Lambda Terraform module:
    • tg_install_python_3
    • tg_python_version
  • The only version allowed at the moment are 3.10 and 3.11 which are the ones available on the package manager repository of the docker image.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

N/A

@yiskaneto yiskaneto changed the title [WIP] - Feat: (issue#48) Add option to install Python3 for projects using TF Lambda module Feat: (issue#48) Add option to install Python3 for projects using TF Lambda module Feb 9, 2024
@yiskaneto
Copy link
Author

@denis256 let me know if this is ok, or if I need to add something else, or if this is a no go. I tested with some internal repos and worked like a charm.

@andresionek91
Copy link

It requires approval from someone who have write access to the project. Not my case unfortunately. But the implementation looks great to me.

@yiskaneto
Copy link
Author

yiskaneto commented Apr 3, 2024

It requires approval from someone who have write access to the project. Not my case unfortunately. But the implementation looks great to me.

Got it, thanks for clarifying!

@danielmapar
Copy link

This is a good solution to get Python rolling, but another solution to this problem is simply to useINPUT_PRE_EXEC_number. Example:

      - name: Run ${{ inputs.terragrunt-command }} in the Terragrunt project
        uses: gruntwork-io/terragrunt-action@v2
        with:
          tf_version: ${{ inputs.terraform-version }}
          tg_version: ${{ inputs.terragrunt-version }}
          tg_dir: ${{ inputs.terragrunt-directory }}
          tg_command: "${{ inputs.terragrunt-command }} --terragrunt-working-dir ${{ inputs.terragrunt-working-dir }}"
        env:
          INPUT_PRE_EXEC_1: "sudo apt update -y && sudo apt install -y python3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to install python3 if a projects uses the terraform aws lambda module
3 participants