Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock oscrypto to fix libcrypto issue with RDP #3958

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Lock oscrypto to fix libcrypto issue with RDP #3958

merged 1 commit into from
Dec 15, 2023

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes part of #3583 .

Oscrypto has not yet released with fix to this issue so we need to lock the commit until oscrypto releases.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb47543) 78.00% compared to head (e8f9297) 78.00%.

❗ Current head e8f9297 differs from pull request most recent head a51ab0f. Consider uploading reports for the commit a51ab0f to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3958   +/-   ##
========================================
  Coverage    78.00%   78.00%           
========================================
  Files          464      464           
  Lines        14664    14664           
========================================
  Hits         11439    11439           
  Misses        3225     3225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but can you explain what it has to do with #3583?

@ilija-lazoroski
Copy link
Contributor Author

Looks fine, but can you explain what it has to do with #3583?

Maybe the issue's title is wrong but there are tasks to rebuild RDP machines. I assume we may or may not introduce this while fixing other things in that issue.

Oscrypto has not yet releasedawith fix to this
wbond/oscrypto#78 so we need to lock the
oscrypto version until the fix is released.

PR #3958
@mssalvatore mssalvatore merged commit eb1b1b3 into develop Dec 15, 2023
1 check failed
@mssalvatore mssalvatore deleted the fix-rdp branch December 15, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants