validators.BugFreeSQL actually validates input sql

[fruttasecca]

Before the change, everything would be passing, for example

from guardrails.validators import BugFreeSQL
v = BugFreeSQL()
invalid_query = "SELECT FROM;"
v.validate("", invalid_query, {})

Note, sqlvalidator has a bunch of open issues that will lead to an uncaught exception, see for example David-Wobrock/sqlvalidator#51, David-Wobrock/sqlvalidator#44. It can't be assumed that the exception is because of the query being invalid, at the same time, a query cannot be considered valid by just catching these exceptions and moving on. I've had the issue come up with fairly trivial examples, e.g. "SELECT ** FROM table;"

[ShreyaR]

Nice catch!

I've been thinking about how to add better sql support because of issues with sqlvalidator similar to the ones you've mentioned. I'm considering using this cli tool https://github.com/jarulraj/sqlcheck instead of sqlvalidator since it seems to be more reliable. Let me know if you have any suggestions!

[fruttasecca]

I've had good luck with https://github.com/tobymao/sqlglot, which would also allow specifying the SQL dialect against which to validate