Proof-of-concept for i18n support #30
Conversation
|
|
|
very cool, @ETBlue do you think i's good to land this? |
| whitelist: ['en', 'zh'], | ||
| debug: true, | ||
| backend: { | ||
| loadPath: 'https://gist.githubusercontent.com/patcon/1f68d3efd30360048bce81b3a7655c5b/raw/{{lng}}.json', |
There was a problem hiding this comment.
this should def point somewhere else, and prob to a raw file on github repo, or a json file hosted as part of app
There was a problem hiding this comment.
yes I think it's better to also include these two json files in the PR
|
bump would love to see this or something like it on the live site so that we can start using this more seamlessly within my english-speaking community :) |
| whitelist: ['en', 'zh'], | ||
| debug: true, | ||
| backend: { | ||
| loadPath: 'https://gist.githubusercontent.com/patcon/1f68d3efd30360048bce81b3a7655c5b/raw/{{lng}}.json', |
There was a problem hiding this comment.
yes I think it's better to also include these two json files in the PR
|
Also, please add some paragraphs in README.md to explain the i18n and how future contribution need to do |
|
Thanks so much @irvin! and is this the right repo to get this into live website, or should I bring it into another repo too? |
|
bump to above. Is this the right repo where this will get deployed to beta.hackfoldr.org? Just curious, as that is my primary motivation :) |
| // i18next | ||
| script(src="//unpkg.com/i18next/i18next.js") | ||
| script(src="//unpkg.com/i18next-xhr-backend/i18nextXHRBackend.js") | ||
| script(src="//unpkg.com/i18next-browser-languagedetector/i18nextBrowserLanguageDetector.js") |
There was a problem hiding this comment.
is it ok to pull these from a CDN?
|
The current change works on my machine. I can't reproduce your deploying problem. Which script do you run when you deploying the app? |
You don’t have this babel error? Also, when I run ./deploy.sh it will have an jade error prevent me from building release html to gh-pages branch, which I should open a new issue and discuss there |
Related: hackfoldr/hackfoldr-2.0#62
Curious if this looks like a workable solution.