Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Sometimes the map shows incorrect area after typing a zipcode into search bar on landing page. #2186

Open
1 task
fancyham opened this issue Aug 13, 2024 · 7 comments · Fixed by #2223
Open
1 task
Assignees
Labels
dev Code Development Missing: Milestone This issue is not part of any milestone p-feature: search Search tool for Food-seekers Priority - High Production requires hotfix Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Front-end Front End Developer size: 3pt The lift to complete this user story 4-8hrs

Comments

@fancyham
Copy link
Collaborator

fancyham commented Aug 13, 2024

Describe the bug

Sometimes the map shows incorrect area after typing a zipcode into search bar on landing page.

This happens only sometimes!

Steps to reproduce the issue

In this video (turn on audio), taken at the beginning of July 2024:

Devlasite_searchbarbug.mp4
  1. User typed in "90013"
  2. Map shows an address in 90045 zip code (as seen in search address field at top of screen)
@fancyham fancyham added Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Front-end Front End Developer p-feature: search Search tool for Food-seekers Ready for dev lead Issue ready for dev lead to review Priority - High Production requires hotfix labels Aug 13, 2024
@fancyham
Copy link
Collaborator Author

@Shienny1 -- FYI, this is based on your bug report from this usability review spreadsheet: https://docs.google.com/spreadsheets/d/1dDZzrwRvulR-TyGP2Gj_NWhS5AzK_drQ5X3xpnuqOFY/edit?gid=0#gid=0

@fancyham fancyham added Priority - Med Needs to be in the next release and removed Priority - High Production requires hotfix labels Aug 13, 2024
@fancyham fancyham changed the title Bug: Sometimes searched addresses get turned into wrong addresses Bug: Sometimes the map shows incorrect area after typing a zipcode into search bar on landing page. Aug 13, 2024
@fancyham fancyham added Priority - High Production requires hotfix dev Code Development and removed Priority - Med Needs to be in the next release labels Aug 13, 2024
@SAUMILDHANKAR SAUMILDHANKAR self-assigned this Sep 10, 2024
@SAUMILDHANKAR
Copy link
Member

@Shienny1 Hi Shienny, I wanted to reach out to you since I am not able to reproduce this error. Maybe it got fixed as part of some other PR but just wanted to check how frequent did you notice the error, I tried around 10-15 times. Also, did the error appear on click or on pressing the enter key? I have noticed an error related to enter key but that may not be exactly related to this issue. Looking forward to hearing from you. Thanks.

@fancyham
Copy link
Collaborator Author

fancyham commented Sep 14, 2024

I was able to reproduce it right now on the public site and on devla on desktop by:

  1. typing "90015" and quickly hitting return on the keyboard
  2. which sometimes resolved to a 90045 address: "Los Angeles, California 90045, United States" in the search field but sometimes stayed "90015" in the text form field, and the map moves to 90045 anyway.

My guess is that whatever algorithm is powering the autocomplete, when the user hits the return key and doesn't select an auto-complete address, the autocomplete fails in unpredictable ways.

Video with audio:

Screen.Recording.2024-09-14.at.1.24.46.PM.mov

@Shienny1
Copy link
Member

@SAUMILDHANKAR Yes this only happens on desktop, because of the speed of hitting "ENTER", just like @fancyham mentioned. I tried it on my mobile devices - this problem does not occur.

@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Sep 20, 2024

Thanks Bryan, Shienny for your help. I am able to reproduce the issue. I am looking into it and would share any update asap.

@SAUMILDHANKAR
Copy link
Member

Reopening this issue since the PR #2223 solution didn't seem to work (as discussed in the meeting today). I will work on reverting the changes of the PR next.

@SAUMILDHANKAR SAUMILDHANKAR reopened this Sep 24, 2024
@sumit-sharma92 sumit-sharma92 added Missing: Size The effort estimate for this issue is missing Missing: Milestone This issue is not part of any milestone labels Sep 26, 2024
@SAUMILDHANKAR SAUMILDHANKAR added size: 3pt The lift to complete this user story 4-8hrs and removed Missing: Size The effort estimate for this issue is missing labels Sep 26, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the Ready for dev lead Issue ready for dev lead to review label Sep 27, 2024
@fancyham
Copy link
Collaborator Author

fancyham commented Oct 2, 2024

Please assign @fancyham and @Shienny1 to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Code Development Missing: Milestone This issue is not part of any milestone p-feature: search Search tool for Food-seekers Priority - High Production requires hotfix Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Front-end Front End Developer size: 3pt The lift to complete this user story 4-8hrs
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

5 participants