Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset zoom when flying to a new location #2229

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

hanapotski
Copy link
Contributor

Addresses #2219

Screen.Recording.2024-09-26.at.7.27.41.PM.mov

Copy link
Member

@junjun107 junjun107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to reset the zoom.
LGTM

@hanapotski
Copy link
Contributor Author

Great idea to reset the zoom. LGTM

that was your idea 🤭 I was thinking of something else but this is easier lol 🙌

@hanapotski hanapotski merged commit 2e3931d into develop Sep 27, 2024
@hanapotski hanapotski deleted the 2219-reset-zoom branch September 27, 2024 02:45
@fancyham
Copy link
Collaborator

*Hi - this is a clever fix for now and if we can push this as a hot-fix, that would be terrific

Long-term, though, we should still figure it out a solution such that the zoom stays the same so that weird/frustrating things don't happen (for example, if you look at 0:16 on the video, clicking on a cluster of locations starts an unintended zoom, which prevents the user from clicking on other items in the cluster, because they've disappeared at the default zoom level). We should keep the map's zoom state what the user last chose when zipping between locations for this reason.

Also, I'm not sure how this works for the original issue's open/closed status -- it doesn't actually fix the problem mentioned there but it but it does make a huge step (i.e. pan to location without the zoom), especially if we can push the hot fix.

Also, I noticed in the video that the first autocomplete entry is 90045... I think that's a hint at why we keep jumping to 90045 if the user types in an address and hits return quickly (before autocomplete finishes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants