Add additional GitHub field and TWE to Project Profile Card Issue Template #7508
Conversation
…ect Profile Card - Added "Tech Work Experience" to the Project Name dropdown after "Open Community Survey" - Added "tech-work-experience.md" to the Project Card URL dropdown after "tdm-calculator.md" - Added a dropdown to ask if volunteers use additional GitHub repositories
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
There was a problem hiding this comment.
Hi @jazxbx thank you for taking on this issue.
Things that you did correctly:
- The branch name is correct
- The changes are good and the indentation is good as well
- The title and the descriptions is clear.
Things that need to be changed:
- You need to add the labels that are on the original issue.
jazxbx
added
role: back end/devOps
Thank you! Just added the missing labels. |
|
@jazxbx the first line of your PR always needs to be in the format "Fixes #XXXX" for the original issue to be linked correctly. That is the reason the labels were not added to this PR and it is currently failing two of the automated checks. Replace that line and it should resolve the check issues. |
Ahh my bad! I thought by doing that, it would close the issue when merged and I didnt want that to happen since there were still some checks I didn't do. |
|
@jazxbx I see, you actually should be able to complete the action items now in your own repo before the PR is merged. If you switch your default branch to the one you made the changes on, the issue template should then reflect the changes. For reference: Changing the default branch. I apologize for not including that step in the initial issue instructions. Once the default branch is updated you can test the template yourself by opening an issue and then let Bonnie know so she can make sure it works as she intended. I'm going to mark this PR as a draft so you can finish those last two items, then you can go ahead and remove the label. |
Ohh will do this! Thank you! |
|
availability: everyday, 5pm - 9pm PST |
There was a problem hiding this comment.
Hi @jazxbx,
Here's what you did correctly:
- changes made and why they were made are clearly stated
- PR title is clear and concise
- branch naming is correct
- changes made to
project-profile-card-review-and-update.ymlare correct - issue on your fork has been successfully created with GitHub fields showing correctly
Requested Changes:
- Seems like you just have the last check remaining (Bonnie testing), so once that is finished feel free to address this request thereafter!
Thanks for your contribution!
fixes #7363
What changes did you make?
When creating an issue using the Project Profile Card review and update template:
-Project Name: Added the option "Tech Work Experience" to the Project Name dropdown
-Project Card URL: Included the "tech-work-experience.md" option in the Project Card URL dropdown.
-Update Github Link section: Added a dropdown menu asking “Do you have any additional (other than your primary) GitHub repositories that your volunteers make issues or PRs against?” with "YES" and "NO" options.
Included a textbox for entering additional repository URLs if the answer is "YES."
Why did you make the changes (we will use this info to test)?
This will allow issues to be submitted for the TWE project card and help us better track a project's resources more accurately
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website
Changes to the template seen in my repo:
https://github.com/jazxbx/website/blob/add-github-field-twe-project-card-7363/.github/ISSUE_TEMPLATE/project-profile-card-review-and-update.yml