Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Danielle Hanson Aras profile under website project #7554

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Add Danielle Hanson Aras profile under website project #7554

wants to merge 1 commit into from

Conversation

minkang3
Copy link
Member

@minkang3 minkang3 commented Oct 1, 2024

Fixes #7457

What changes did you make?

  • Added the profile of Danielle Hanson Aras under the "Current Project Team" section of the "Hack for LA Site" project.
  • Added the variables name, github-handle, role, links, slack, github, and picture.

Why did you make the changes (we will use this info to test)?

  • The project information regarding the current project team was out of date.
  • Danielle was a team member but the website was not updated to display that.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b minkang3-add-danielle-hanson-aras-project-profile-7457 gh-pages
git pull https://github.com/minkang3/website.git add-danielle-hanson-aras-project-profile-7457

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization size: 0.5pt Can be done in 3 hours or less labels Oct 1, 2024
@mrodz mrodz self-requested a review October 1, 2024 16:20
@mrodz
Copy link
Member

mrodz commented Oct 1, 2024

Availability: Weekdays 4-11pm
ETA: 5PM 10/1

@ramitaarora ramitaarora self-requested a review October 1, 2024 17:52
@ramitaarora
Copy link
Member

Availability: Weekday mornings
ETA: Oct 1

mrodz
mrodz approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@mrodz mrodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @minkang3! Your changes look great.

  • Proper branch names, linked issue
  • Good description of the issue, changes, fixes, etc.
  • Correctly added name, github-handle, role, links, and picture
  • Ensured that the name is correct, the GitHub links are correct, and the Slack URL is correct
  • Follows the style of the other members in the YAML object

Keep up the good work!

@mrodz mrodz mentioned this pull request Oct 1, 2024
Open
31 tasks
@codyyjxn codyyjxn self-requested a review October 2, 2024 03:40
@codyyjxn
Copy link
Member

codyyjxn commented Oct 2, 2024

Availability: Weekday
ETA:E EOD

codyyjxn
codyyjxn approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @minkang3 good job on your small issue.
The branch name is correct.
The changes seems to be correct as well.
The description and the title are clear and concise the screenshots are good for visuals.

ramitaarora
ramitaarora approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, this looks great!

  • You issue is correctly linked and from your own branch
  • You used spaces, not tabs
  • I verified the new profile shows up on projects/website

Thank you for contributing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodz mrodz mrodz approved these changes

@ramitaarora ramitaarora ramitaarora approved these changes

@codyyjxn codyyjxn codyyjxn approved these changes

Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Ready for Prioritization role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Status: test-approved-by-reviewer (Automated Column, do not place items here manually)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website : Add Danielle Hanson Aras
4 participants
@minkang3 @mrodz @ramitaarora @codyyjxn