Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use a timer for an explicit timeout of 0 #1146

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Do not use a timer for an explicit timeout of 0 #1146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78011d1
Do not use a timer for an explicit timeout of 0
cduivis Oct 12, 2017
9b1e9da
Removed a trailing white-space
cduivis Oct 13, 2017
e178bb1
Refactored to adjust to the coding styles
cduivis Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utils/set-timeout-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,10 @@ import bindFn from './bind-fn';
* @returns {number}
*/
export default function setTimeoutContext(fn, timeout, context) {
return setTimeout(bindFn(fn, context), timeout);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use resolve().then to schedule a microtask (high priority with immediate flush) to ensure we preserve async semantics.

if (timeout === 0) {
fn.call(context);
return null;
} else {
return setTimeout(bindFn(fn, context), timeout);
}
}