Refactor for clearer logs

haphamdev · Mar 13, 2024 · f8e8ad2 · f8e8ad2
1 parent ba203da
commit f8e8ad2
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/src/main/kotlin/Main.kt b/src/main/kotlin/Main.kt
@@ -39,13 +39,15 @@ fun main() {
                 .map { constraint ->
                     when (constraint.itemType) {
                         ChargebeeItemConstraint.ItemType.PLAN -> {
+                            if (constraint.targetType == ChargebeeItemConstraint.TargetType.NONE) return@map constraint
                             appliedToPlan = true
                             val checkResult = checkPlanConstraint(constraint, discount)
                             if (checkResult.manualCheckNeeded) manualCheckNeeded = true
                             return@map checkResult.constraint
                         }
 
                         ChargebeeItemConstraint.ItemType.ADDON -> {
+                            if (constraint.targetType == ChargebeeItemConstraint.TargetType.NONE) return@map constraint
                             appliedToAddon = true
                             val checkResult = checkAddonConstraint(
                                 constraint,
@@ -61,8 +63,10 @@ fun main() {
                         }
 
                         ChargebeeItemConstraint.ItemType.CHARGE -> {
-                            println("Coupon ${discount.id} is applied to CHARGES. Manual check needed.")
-                            manualCheckNeeded = true
+                            if (constraint.targetType != ChargebeeItemConstraint.TargetType.NONE) {
+                                println("Coupon ${discount.id} is applied to CHARGES. Manual check needed.")
+                                manualCheckNeeded = true
+                            }
                             return@map constraint
                         }
                     }
@@ -73,10 +77,10 @@ fun main() {
                 println("Coupon ${discount.id} is applied to both PLANS and ADDONS. Manual check needed")
             }
 
-            if (updatedConstraints.any { !discount.itemConstraints.contains(it) }) {
-                if (manualCheckNeeded) {
-                    println("Skip coupon ${discount.id} for manual check")
-                } else if (!DRY_RUN ) {
+            if (manualCheckNeeded) {
+                println("Skip coupon ${discount.id} for manual check")
+            } else if (updatedConstraints.any { !discount.itemConstraints.contains(it) }) {
+                if (DRY_RUN) {
                     println("Skip updating coupon ${discount.id} in DRY RUN mode")
                 } else {
                     println("Updating coupon ${discount.id}...")