Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve alternatives type #2981

Merged
merged 5 commits into from
Oct 4, 2023
Merged

feat: Improve alternatives type #2981

merged 5 commits into from
Oct 4, 2023

Conversation

felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Aug 24, 2023 •
edited
Loading

closes #2980

Before

image

After

image

with different types
image

with try
image

with conditional
image

image

@felixmosh felixmosh force-pushed the improve-alternative-types branch 2 times, most recently from d2be019 to ecb1bf4 Compare August 24, 2023 13:15
Marsup
Marsup reviewed Aug 27, 2023
View reviewed changes
lib/index.d.ts Outdated Show resolved Hide resolved
@Marsup Marsup self-assigned this Oct 4, 2023
@Marsup Marsup added the types TypeScript type definitions label Oct 4, 2023
@Marsup Marsup added this to the 18.0.0 milestone Oct 4, 2023
@Marsup Marsup merged commit 6dbe77d into hapijs:master Oct 4, 2023
9 checks passed
@Marsup
Copy link
Collaborator

Marsup commented Oct 4, 2023

Thanks a lot for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marsup Marsup Marsup left review comments

Assignees

@Marsup Marsup

Labels
types TypeScript type definitions
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.

Types of alternative are wrong always resolves to any
2 participants
@felixmosh @Marsup