Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle bigint in unique rule #3026

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

copoix-ultra
Copy link
Contributor

@copoix-ultra copoix-ultra commented Mar 29, 2024

When trying to validate uniqueness on bigint type arrays, the error Failed to find unique map container for type bigint is returned.

this PR adds handling bigint as a native type without having to provide a compare function and treat it as custom

@copoix-ultra copoix-ultra changed the title handle bigint in unique rule fix: handle bigint in unique rule Mar 29, 2024
test/types/array.js Outdated Show resolved Hide resolved
@Marsup Marsup self-assigned this Apr 3, 2024
@Marsup Marsup added the bug Bug or defect label Apr 3, 2024
@Marsup Marsup added this to the 17.12.3 milestone Apr 3, 2024
@Marsup
Copy link
Collaborator

Marsup commented Apr 3, 2024

Thanks!

@Marsup Marsup merged commit 5b96852 into hapijs:master Apr 3, 2024
9 checks passed
Marsup pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants