Scripts of registering discovered locations, create and delete servic… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for value in response["values"]: | ||
| if "path" in value: | ||
| path = value["path"] | ||
| match = re.search(r"mock_rserver_root/configs/services/(.*?-service)", path) |
There was a problem hiding this comment.
We should use the catalog_path declared above instead of hardcoding the regex here
| print(f"Failed to fetch the latest commit. Status code: {response.status_code}") | ||
| exit() | ||
|
|
||
| def extract_directories(response): |
There was a problem hiding this comment.
Can we move this method to the top (after the variable declarations) OR to the bottom?
Right now it's kind of in between the code flow which affects readability
…es for bitbucket monorepo usecase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es for bitbucket monorepo usecase