Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "prism.js" to un-minified v1.15.0 (Closes: #3005) #3006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

onlyjob
Copy link

@onlyjob onlyjob commented Jul 8, 2018

Open source compliance. Documented origin URL and LICENSE.

I'm unable to do full library transition.
Some CSS and code updates may be required to complete Prism update.

Open source compliance. Documented origin URL and LICENSE.

Signed-off-by: Dmitry Smirnov <[email protected]>
Copy link
Collaborator

@koenpunt koenpunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely think that we're not required to provide the .license and/or .url files.
However I would accept a PR that updates the (minified) Prism library, and the usage thereof.

@onlyjob
Copy link
Author

onlyjob commented Jul 11, 2018

Ideally it would not be required to provide license and URL files yet it is a good idea (and good practice) to document origin of the file and its license.

On this instance LiICENSE and URL files are required because file's header contains no information about its license, version or origin.

@JJJ JJJ mentioned this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants