Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: ensure sessionControls.isEnabled: true when specifying sign_in_frequency_interval = "everyTime" #1417

Merged
merged 1 commit into from
Aug 19, 2024
Merged

bugfix: ensure sessionControls.isEnabled: true when specifying sign_in_frequency_interval = "everyTime" #1417

merged 1 commit into from
Aug 19, 2024

Conversation

manicminer
Copy link
Contributor

This fixes some incorrect logic around enabling session controls when only sign_in_frequency_interval = "everyTime" is specified.

Unfortunately this is currently blocked due to a possible API bug - this field doesn't seem to be accepted by the v1.0 API contrary to documentation. Changing the API version in the request to beta allows the request to complete.

Screenshot 2024-06-25 at 23 10 26

Screenshot 2024-06-25 at 23 11 38

Closes: #1416

@manicminer manicminer mentioned this pull request Jun 25, 2024
Open
@manicminer
Copy link
Contributor Author

API bug reported upstream: microsoftgraph/msgraph-metadata#647

jackofallops
jackofallops approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 2cebdb1 into main Aug 19, 2024
24 checks passed
@manicminer manicminer deleted the bugfix/conditional-access-session-controls-sign-in-frequency-interval branch August 19, 2024 16:06
@github-actions github-actions bot added this to the v2.54.0 milestone Aug 19, 2024
@manicminer manicminer mentioned this pull request Aug 19, 2024
Merged
@manicminer
Copy link
Contributor Author

Note: merged in error, now reverted. This continues to be blocked.

@github-actions GitHub Actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

1 similar comment
@github-actions GitHub Actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
api-bug bug feature/conditional-access size/S upstream-microsoft
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

azuread_conditional_access_policy - BadRequest with sign_in_frequency_interval = "everyTime"
2 participants
@manicminer @jackofallops