Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-838: Full MARC record output #28

Merged
merged 2 commits into from
May 24, 2024
Merged

DEV-838: Full MARC record output #28

merged 2 commits into from
May 24, 2024

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Feb 28, 2024

  • marc21_full metadata format with full records (save the special Zephir-specific fields)

  • additional description element for Identify with reference to metadata sharing policy, access & use policy

@coveralls
Copy link

coveralls commented Feb 28, 2024

Coverage Status

coverage: 99.038% (-1.0%) from 100.0%
when pulling e6b3651 on DEV-838-full-marc
into ded649c on main.

- marc21_full metadata format with full records (save the special
  Zephir-specific fields)

- additional description element for Identify with reference to metadata
  sharing policy, access & use policy
@aelkiss
Copy link
Member Author

aelkiss commented Mar 1, 2024

Can't merge this at the current time due to policy issues, but feel free to review & then we should close without merging.

@aelkiss aelkiss marked this pull request as draft April 1, 2024 16:30
@aelkiss
Copy link
Member Author

aelkiss commented May 2, 2024

@moseshll Since we can't use this as-is, any thoughts on whether we might want to put a feature gate in place so it isn't active and then review/merge this, or just close this PR with no action? I have no idea of the likelihood of ever being able to enable this. The risk if we close this (but leave the branch open) is future merge conflicts/difficulty integrating if we do end up being able to do it.

@moseshll
Copy link
Contributor

moseshll commented May 3, 2024

My opinion: add a gate and merge. I dare to suspect that controlling the feature with an ENV variable (no var set meaning "feature off") will suffice and keep the specs/coverage sparkly. As opposed to scattering if false here and there.

@aelkiss
Copy link
Member Author

aelkiss commented May 23, 2024

@moseshll See what you think. I hesitate to make this more dynamic (e.g. just based on a setting at startup) in part because it's difficult to test, and we don't have a near-term ability to release this functionality.

@aelkiss aelkiss marked this pull request as ready for review May 23, 2024 16:22
* Leaves unit tests for MARC21 full output enabled
* Removes it from provider configuration
* Integration tests check that MARC21 full output is not enabled
Copy link
Contributor

@moseshll moseshll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me with both scenarios: full MARC disabled and enabled.

@aelkiss aelkiss merged commit 0fdf9f0 into main May 24, 2024
1 check passed
@aelkiss aelkiss deleted the DEV-838-full-marc branch May 24, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants