[HxRadioButtonList][HxCheckboxList] Adds Toogle buttons to Radio and Checkbox lists #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds toggle option to HxRadioButtonList and HxCheckboxList
…s://github.com/mmonteagudo/Havit.Blazor into feature/HxRadio_CheckButtonListBase-ToggleView
|
@mmonteagudo Thanks for submitting this PR. I'd like to build on the base you've provided and fine-tune this feature so we can release it to production. @crdo Could you please take a look and add your review? |
Open
Open
hakenr
reviewed
Sep 23, 2024
Comment on lines
+152
to
+157
| if (inputAsToggleEffective != Bootstrap.InputAsToggle.Toggle) | ||
| { | ||
| builder.OpenElement(100, "div"); | ||
| // TODO CoreCssClass | ||
| builder.AddAttribute(101, "class", CssClassHelper.Combine("form-check", Inline ? "form-check-inline" : null, ItemCssClassImpl, ItemCssClassSelectorImpl?.Invoke(item))); | ||
| } |
There was a problem hiding this comment.
Careful, this ignores ItemCssClass and ItemCssClassSelector for toggle buttons.
We need to decide whether we can make these work somehow, or if the combination with toggle buttons will be unsupported (in which case, we should probably throw an exception in OnParametersSet).
| /// <summary> | ||
| /// Input as toggle or regular. | ||
| /// </summary> | ||
| [Parameter] public InputAsToggle? InputAsToggle { get; set; } |
There was a problem hiding this comment.
The API is up for discussion in the related issue #887.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intent to add the Bootstrap Toogle buttons view for radio and checkbox lists https://getbootstrap.com/docs/5.3/forms/checks-radios/#toggle-buttons