Work around Bash buffering bug causing test failures #766
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boot tests run several iterations inside a single 'heroku run', as rthis drastically reduces the overall time taken for tests. Some Bash 5.0 bug (it seems to happen only on heroku-20) causes output from a command (that is still running through a tee process substitution) to arrive a bit after the next echo statement, and as a result, sometimes, the last line of a delimited chunk is not the exit status, but output from the program, causing the test to fail. So we just write outputs to files, and cat them together at the end.
runesoerensen
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boot tests run several iterations inside a single
heroku run, as this drastically reduces the overall time taken for tests.Some Bash 5.0 bug (it seems to happen only on heroku-20) causes output from a command (that is still running through a
teeprocess substitution) to arrive a bit after the nextechostatement, and as a result, sometimes, the last line of a delimited chunk is not the exit status, but output from the program, causing the test to fail.So we just write outputs to files, and
catthem together at the end.GUS-W-17294876