Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update theme Arknights info #2029

Merged
merged 1 commit into from
Aug 14, 2023
Merged

update theme Arknights info #2029

merged 1 commit into from
Aug 14, 2023

Conversation

Yue-plus
Copy link
Contributor

@Yue-plus Yue-plus commented Jul 9, 2023 •
edited
Loading

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)
    • Languages:
    • en English
    • ru Russian
    • zh-cn simplified Chinese
    • zh-tw traditional Chinese

Note

No need to translate ko, pt-br, th languages if you submit a PR for documentation.

Warning

ko, pt-br, th languages document are inactive. Please, submit issue if you want to continuous contribution to them.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Theme name validation passed.
Theme thumbnails validation completed.

yoshinorin
yoshinorin requested changes Aug 6, 2023
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yue-plus
Sorry, we are splitted themes.yml in PR #2038
Would you please create a new PR ?

Please see how to submit a new your theme.yml.

https://github.com/hexojs/site/pull/2042/files

@stevenjoezhang stevenjoezhang merged commit 6694cbe into hexojs:master Aug 14, 2023
4 checks passed
@Yue-plus Yue-plus deleted the Yue branch August 14, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin requested changes

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yue-plus @yoshinorin @stevenjoezhang